New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect Docker also using /.dockerenv #1400

Merged

shirou merged 1 commit into shirou:master from scop:dockerenv

Dec 30, 2022

Contributor

scop commented Dec 28, 2022

Docker itself does that too, for example in https://github.com/moby/libnetwork/blob/1f3b98be6833a93f254aa0f765ff55d407dfdd69/drivers/bridge/setup_bridgenetfiltering.go#L161

/proc/self/cgroup doesn't necessarily contain "docker".


          Detect Docker also using /.dockerenv

70a8f58

shirou approved these changes

View reviewed changes

Owner

shirou left a comment

Good catch! Thank you!

shirou merged commit ca886f9 into shirou:master

shirou added a commit that referenced this pull request


          chore(README): add HOST_ROOT introduced by #1400

46c4ce3

shirou mentioned this pull request

chore(README): add HOST_ROOT #1401

Merged

scop deleted the dockerenv branch

December 30, 2022 09:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet